[PATCH] Libertas 5.110.5 -> 5.110.7 upgrade
Marcelo Tosatti
marcelo at kvack.org
Wed Jun 7 10:14:27 EDT 2006
On Tue, Jun 06, 2006 at 10:42:05PM +0100, David Woodhouse wrote:
> On Tue, 2006-06-06 at 18:13 -0300, Marcelo Tosatti wrote:
> > --- a/drivers/net/wireless/libertas/wlanconfig/wlanconfig.c
> > +++ b/drivers/net/wireless/libertas/wlanconfig/wlanconfig.c
> > @@ -54,9 +54,9 @@ typedef unsigned char u8;
> > typedef unsigned short u16;
> > typedef unsigned long u32;
> > typedef unsigned long long u64;
> > -typedef signed char s8;
> > -typedef signed short s16;
> > -typedef signed long s32;
> > +typedef char s8;
> > +typedef short s16;
> > +typedef long s32;
>
> First, isn't this userspace? The silly 'u16' types don't belong in
> userspace. Use the standard uint16_t, or perhaps __u16 if you must.
>
> Second, 'char' isn't necessarily signed, and 'long' isn't necessarily 32
> bits.
David,
The plan is to kill wlanconfig.c and use iwpriv for driver private
ioctl's instead.
But yeah, this typedef's were and still continue to be wrong.
More information about the libertas-dev
mailing list