[PATCH] Libertas 5.110.5 -> 5.110.7 upgrade
David Woodhouse
dwmw2 at infradead.org
Tue Jun 6 17:42:05 EDT 2006
On Tue, 2006-06-06 at 18:13 -0300, Marcelo Tosatti wrote:
> --- a/drivers/net/wireless/libertas/wlanconfig/wlanconfig.c
> +++ b/drivers/net/wireless/libertas/wlanconfig/wlanconfig.c
> @@ -54,9 +54,9 @@ typedef unsigned char u8;
> typedef unsigned short u16;
> typedef unsigned long u32;
> typedef unsigned long long u64;
> -typedef signed char s8;
> -typedef signed short s16;
> -typedef signed long s32;
> +typedef char s8;
> +typedef short s16;
> +typedef long s32;
First, isn't this userspace? The silly 'u16' types don't belong in
userspace. Use the standard uint16_t, or perhaps __u16 if you must.
Second, 'char' isn't necessarily signed, and 'long' isn't necessarily 32
bits.
--
dwmw2
More information about the libertas-dev
mailing list