[PATCH 1/1] idiag: fix set of identifying properties for idiag_msg_obj

Cong Wang xiyou.wangcong at gmail.com
Thu Nov 27 07:14:41 PST 2014


On Wed, Nov 26, 2014 at 3:34 AM, Thomas Haller <thaller at redhat.com> wrote:
> Hi Cong,
>

Hi,

> how about this now? I actually don't know which fields constitute
> the identifying properties. I think having state there is wrong.
>

I agree.

> Can you verify that now it is correct? Note that for this to be correct,
> these 5 properties must always be present in every (valid) idiag_msg_obj
> and they must never change -- for the same instance.
>

I can't test it now, because I am on vacation. But it looks good
to my eyes. :)

Thanks for the patch!



More information about the libnl mailing list