[PATCH v2 0/4] lib/socket: use proper typed constant UINT32_MAX for uint32_t typed port

Thomas Haller thaller at redhat.com
Tue May 6 05:47:45 PDT 2014


On Wed, 2014-04-09 at 12:16 +0200, Thomas Haller wrote:
> On Wed, 2014-04-09 at 12:08 +0200, Thomas Haller wrote:
> > Rework the 3 patches sent on "Tue,  8 Apr 2014 14:06:24 +0200",
> > including some bugfixes and actual testing of the code.
> > It seems to work correctly now (which it didn't before).
> > 
> > I also included the patch from "Mon,  7 Apr 2014 20:26:51 +0200"
> > > [PATCH 1/1] lib/socket: randomize the generated local port
> > so, that one is obsolete as well.
> > The "randomization" now also shuffles the order of how to access the
> > lower 32 bits. In testing, this actually makes a lot of a difference.
> 
> 
> For the record, I attach the python script I used to test this.
> 
> Thomas


All 4 patches merged to master.


*   https://github.com/thom311/libnl/commit/e21099908f6e22d869b2b8eeb1ffbcc2eff209e4
|\  
| * https://github.com/thom311/libnl/commit/1f734a8f892abcd3f81637df4a089155aca1b66a
| * https://github.com/thom311/libnl/commit/4dd5fdd0af2c0b7ffe1dbc49313f263dbb2e906f
| * https://github.com/thom311/libnl/commit/0271578987088210d7d2d68addbd5e8fe27d4383
| * https://github.com/thom311/libnl/commit/0fd510b3673f479637a6376db3d66dcb9f8911d0
|/  
*


The version v2 send to mailing list had several bugs. So, what I finally merged is
quite different again.


For the record, I also attach the python script that I used to test it.
(it changed a bit from the previous version).


Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nl_connect.py
Type: text/x-python
Size: 2713 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20140506/0ed6fb42/attachment.py>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20140506/0ed6fb42/attachment.sig>


More information about the libnl mailing list