[PATCH 1/1] fixup! veth: grab a reference for rtnl_link_veth_get_peer()

Cong Wang xiyou.wangcong at gmail.com
Tue Apr 29 10:24:58 PDT 2014


On Mon, Apr 28, 2014 at 7:35 AM, Thomas Haller <thaller at redhat.com> wrote:
> ---
> Hi Cong,
>
> I am pretty sure that you need to change rtnl_link_veth_add()
> and veth_free() not to leak the peer (or am I wrong??).

Oops, yes of course. I think we can just use ->l_info directly as we
use it in other places as well.

>
> (and a minor change in utils.h, that I got wrong in my previous
> patch).
>

Ok, I will send v3.

Thanks!



More information about the libnl mailing list