[bug] wrong function declaration rtnl_class_dsmark_{set,get}_bitmask

Thomas Graf tgraf at infradead.org
Fri Nov 25 10:10:38 EST 2011


On Fri, Nov 25, 2011 at 11:07:16AM +0100, Julien BERNARD wrote:
> Hi,
> 
> I think there is a mistake with
> rtnl_class_dsmark_{set,get}_bitmask()
> from lib/route/qdisc/dsmark.c which are declared as
> rtnl_class_dsmark_{set,get}_bmask()
> in include/netlink/route/qdisc/dsmark.h.
> 
> As a consequence these functions can not be used unless we declare
> them correctly.

You are absolutely right. Fixed in:

commit 4a7791eca1268e24225c33ed1c00c140a14cd955
Author: Thomas Graf <tgraf at redhat.com>
Date:   Fri Nov 25 16:08:25 2011 +0100

    dsmark: Add missing declarations for rtnl_class_dsmark_(get|set)_bitmask()
    
    The existing declarations refered to non-existing functions so removing
    them is safe.
 



More information about the libnl mailing list