libertas: Fix lbs_prb_rsp_limit_set()

Kalle Valo kvalo at codeaurora.org
Wed Jun 28 11:18:22 PDT 2017


Dan Carpenter <dan.carpenter at oracle.com> wrote:

> The kstrtoul() test was reversed so this always returned -ENOTSUPP.
> 
> Fixes: 27d7f47756f4 ("net: wireless: replace strict_strtoul() with kstrtoul()")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> Reviewed-by: James Cameron <quozl at laptop.org>
> 
> diff --git a/drivers/net/wireless/marvell/libertas/mesh.c b/drivers/net/wireless/marvell/libertas/mesh.c
> index eeeb892219aa..37ace5cb309d 100644
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -233,8 +233,9 @@ static ssize_t lbs_prb_rsp_limit_set(struct device *dev,
>  	memset(&mesh_access, 0, sizeof(mesh_access));
>  	mesh_access.data[0] = cpu_to_le32(CMD_ACT_SET);
>  
> -	if (!kstrtoul(buf, 10, &retry_limit))
> -		return -ENOTSUPP;
> +	ret = kstrtoul(buf, 10, &retry_limit);
> +	if (ret)
> +		return ret;
>  	if (retry_limit > 15)
>  		return -ENOTSUPP;

Patch applied to wireless-drivers-next.git, thanks.

69551f5f370c libertas: Fix lbs_prb_rsp_limit_set()

-- 
https://patchwork.kernel.org/patch/9806775/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




More information about the libertas-dev mailing list