From baspeters93 at gmail.com  Wed Feb 11 00:33:06 2015
From: baspeters93 at gmail.com (Bas Peters)
Date: Wed, 11 Feb 2015 09:33:06 +0100
Subject: [PATCH] net: wireless: libertas: debugfs.c: remove unnecessary check
 before calling debugfs_remove
Message-ID: <1423643586-11002-1-git-send-email-baspeters93@gmail.com>

Debugfs_remove will check for error or NULL for us, so it is not
necessary to do this here.

Signed-off-by: Bas Peters <baspeters93 at gmail.com>
---
 drivers/net/wireless/libertas/debugfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index cc6a0a5..26cbf1d 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -742,8 +742,7 @@ void lbs_debugfs_init(void)
 
 void lbs_debugfs_remove(void)
 {
-	if (lbs_dir)
-		 debugfs_remove(lbs_dir);
+	debugfs_remove(lbs_dir);
 }
 
 void lbs_debugfs_init_one(struct lbs_private *priv, struct net_device *dev)
-- 
2.1.0



From quozl at laptop.org  Mon Feb 23 14:03:32 2015
From: quozl at laptop.org (James Cameron)
Date: Tue, 24 Feb 2015 09:03:32 +1100
Subject: Fwd: XO (88W8388) roaming issues
In-Reply-To: <CANvdtoURgRUrGJevCP5ZCGZxbBppLtWo_e2+UiQrG=S_jh2eEA@mail.gmail.com>
References: <CANvdtoUCyUOYj01-bygF5x4cw=yUM+2YbWv6W1+SzN7KSjiqLQ@mail.gmail.com>
 <1364330083.1514.53.camel@dcbw.foobar.com>
 <CANvdtoVLJjPUOb4gJAKSjrwbyo5BaU2aZyFBzb0N6uB7RkHB_w@mail.gmail.com>
 <1364391747.1500.6.camel@dcbw.foobar.com>
 <CANvdtoX2KjfybKe9Ft5_Z6rFvzP61J3MHWx1WTyiQWxaWYv=OA@mail.gmail.com>
 <1364399086.3324.2.camel@dcbw.foobar.com>
 <CANvdtoWMrH8Pvmg9shi8DY+QNSM-Yya7buYgy9HwRPraMx7BKw@mail.gmail.com>
 <CANvdtoU+nO6gM8tLveSVTryeUN2BsX8WwfkkU9WSQqGCDhmOVg@mail.gmail.com>
 <CANvdtoURgRUrGJevCP5ZCGZxbBppLtWo_e2+UiQrG=S_jh2eEA@mail.gmail.com>
Message-ID: <20150223220332.GC16544@us.netrek.org>

On Mon, Aug 19, 2013 at 02:05:32PM -0300, Franco Miceli wrote:
> We have been running some tests on different machines, of different
> model, in order to verify the patch's thresholds.
> 
> Roaming performance is now more stable. I am attaching the test
> results as a PDF.

These tests were on a driver that would occasionally destroy scan
results.  This was fixed in February 2014:

libertas: fix scan result loss if SSID IE len 0
95320774fae71d7b22b970ef4267fcc4d1ad23d8

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/libertas/cfg.c?id=95320774fae71d7b22b970ef4267fcc4d1ad23d8

I'm not sure if there was an impact on wpa_supplicant, but in my
experience roaming was improved.

(The message quoted above was released from mailing list moderation
queue after a year and a half.)

-- 
James Cameron
http://quozl.linux.org.au/


From fmiceli at plan.ceibal.edu.uy  Tue Feb 24 06:19:38 2015
From: fmiceli at plan.ceibal.edu.uy (Franco Miceli)
Date: Tue, 24 Feb 2015 12:19:38 -0200
Subject: Fwd: XO (88W8388) roaming issues
In-Reply-To: <20150223220332.GC16544@us.netrek.org>
References: <CANvdtoUCyUOYj01-bygF5x4cw=yUM+2YbWv6W1+SzN7KSjiqLQ@mail.gmail.com>
 <1364330083.1514.53.camel@dcbw.foobar.com>
 <CANvdtoVLJjPUOb4gJAKSjrwbyo5BaU2aZyFBzb0N6uB7RkHB_w@mail.gmail.com>
 <1364391747.1500.6.camel@dcbw.foobar.com>
 <CANvdtoX2KjfybKe9Ft5_Z6rFvzP61J3MHWx1WTyiQWxaWYv=OA@mail.gmail.com>
 <1364399086.3324.2.camel@dcbw.foobar.com>
 <CANvdtoWMrH8Pvmg9shi8DY+QNSM-Yya7buYgy9HwRPraMx7BKw@mail.gmail.com>
 <CANvdtoU+nO6gM8tLveSVTryeUN2BsX8WwfkkU9WSQqGCDhmOVg@mail.gmail.com>
 <CANvdtoURgRUrGJevCP5ZCGZxbBppLtWo_e2+UiQrG=S_jh2eEA@mail.gmail.com>
 <20150223220332.GC16544@us.netrek.org>
Message-ID: <CANvdtoUGnfQ43cdRx+PrQAdpuoqmxcJK8y3tVqiCDzpCERB9WA@mail.gmail.com>

I think the proposed change to wpa_supplicant's roaming thresholds was
never pushed mainstream.

Dan, could you confirm this?

Anyway, we tested the changes on several laptop models (XO, classmate
and regular laptops) and roaming stability was improved. We had a
ping-pong station problem on our deployment.

Any new information on this toppics is greatly appreciated.

Regards,

2015-02-23 20:03 GMT-02:00 James Cameron <quozl at laptop.org>:
> On Mon, Aug 19, 2013 at 02:05:32PM -0300, Franco Miceli wrote:
>> We have been running some tests on different machines, of different
>> model, in order to verify the patch's thresholds.
>>
>> Roaming performance is now more stable. I am attaching the test
>> results as a PDF.
>
> These tests were on a driver that would occasionally destroy scan
> results.  This was fixed in February 2014:
>
> libertas: fix scan result loss if SSID IE len 0
> 95320774fae71d7b22b970ef4267fcc4d1ad23d8
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/libertas/cfg.c?id=95320774fae71d7b22b970ef4267fcc4d1ad23d8
>
> I'm not sure if there was an impact on wpa_supplicant, but in my
> experience roaming was improved.
>
> (The message quoted above was released from mailing list moderation
> queue after a year and a half.)
>
> --
> James Cameron
> http://quozl.linux.org.au/



-- 

Ing. Franco Miceli
Jefe de Investigaci?n, desarrollo e innovaci?n | ?rea t?cnica
Tel: (598) 2601 5773 int.: 2232
Av. Italia 6201 | CP 11500 | Montevideo, Uruguay


From kvalo at codeaurora.org  Fri Feb 27 00:07:20 2015
From: kvalo at codeaurora.org (Kalle Valo)
Date: Fri, 27 Feb 2015 08:07:20 +0000 (UTC)
Subject: libertas: remove unnecessary check before calling debugfs_remove
In-Reply-To: <1423643586-11002-1-git-send-email-baspeters93@gmail.com>
Message-ID: <20150227080720.BA59C13FA62@smtp.codeaurora.org>


> Debugfs_remove will check for error or NULL for us, so it is not
> necessary to do this here.
> 
> Signed-off-by: Bas Peters <baspeters93 at gmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo


