[patch -next] libertas: precedence bug
Dan Williams
dcbw at redhat.com
Thu Jul 22 18:24:54 EDT 2010
On Thu, 2010-07-22 at 14:21 +0200, Dan Carpenter wrote:
> Negate has precedence over comparison so the original test was always
> false. (Neither 0 nor 1 are equal to NL80211_IFTYPE_MONITOR).
>
> Signed-off-by: Dan Carpenter <error27 at gmail.com>
Acked-by: Dan Williams <dcbw at redhat.com>
> diff --git a/drivers/net/wireless/libertas/tx.c b/drivers/net/wireless/libertas/tx.c
> index 411a3bb..8000ca6 100644
> --- a/drivers/net/wireless/libertas/tx.c
> +++ b/drivers/net/wireless/libertas/tx.c
> @@ -180,7 +180,7 @@ void lbs_send_tx_feedback(struct lbs_private *priv, u32 try_count)
> {
> struct tx_radiotap_hdr *radiotap_hdr;
>
> - if (!priv->wdev->iftype == NL80211_IFTYPE_MONITOR ||
> + if (priv->wdev->iftype != NL80211_IFTYPE_MONITOR ||
> priv->currenttxskb == NULL)
> return;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the libertas-dev
mailing list