[PATCH] Libertas: Fix issues while configuring host sleep

Bing Zhao bzhao at marvell.com
Mon Nov 9 19:00:55 EST 2009


Hi Kalle,

> -----Original Message-----
> From: Kalle Valo [mailto:kalle.valo at gmail.com] On Behalf Of Kalle Valo
> Sent: Saturday, November 07, 2009 2:54 AM
> To: Bing Zhao
> Cc: John W. Linville; libertas-dev at lists.infradead.org; linux-wireless at vger.kernel.org; Amitkumar
> Karwar
> Subject: Re: [PATCH] Libertas: Fix issues while configuring host sleep
> 
> Bing Zhao <bzhao at marvell.com> writes:
> 
> >> The reformatting is a distraction.  It would be better to do just
> >> the fix part separately, especially if you are targetting 2.6.32.
> >
> > Without the reformatting, the change would be like this:
> >
> > +	if (wol->wolopts == 0)    criteria |= EHS_REMOVE_WAKEUP;
> >
> > But the "checkpatch.pl" script gave me an error on that:
> > "ERROR: trailing statements should be on next line"
> 
> You can do the reformatting in the first patch and the second patch
> would contain the actual fix.

I will re-submit as suggested.

Thanks,

Bing

> 
> --
> Kalle Valo



More information about the libertas-dev mailing list