[PATCH 2/2] Sysfs interface for accessing non-volatile configuration.

[Javier Cardona]

Holger,

Thanks for your comments.

On Tue, May 20, 2008 at 1:07 AM, Holger Schurig
<hs4233 at mail.mn-solutions.de> wrote:
> *) a runtime check (e.g. by comparing firmware version) if
>   the firmware supports mesh at all, and then doing this only
>   in that case. Probably as lbs_has_mesh() call, we're going
>   to need this in several places
>
> *) a kernel-config option, because many people use CF/SDIO
>   cards in embedded environmnents and like to have things
>   small. No need for #ifdef/#endif, because the compiler can
>   savely optimize things out: "#define lbs_has_mesh() (0)"
>   if mesh is turned off via Kconfig.

Is David's suggestion acceptable to you?

On Sat, 2008-05-17 at 21:01 -0700, David Woodhouse wrote:
> As Holger points out, we should call those only if (priv->mesh_tlv).

> Also, you create /sys/class/net/ethX/mesh_ie. This doesn't make
> sense to me. /sys/class/net/mshX/boot_options seems to be more
> logical. However, I don't know much about mesh ...

The entries in the mesh_ie directory groups the non-volatile
parameters of the mesh Information Element that is included in all
mesh beacons.

Javier

-- 
Javier Cardona
cozybit Inc.