[PATCH] move wlan_*_association_work from header to c file
Dan Williams
dcbw at redhat.com
Thu Oct 11 10:50:34 EDT 2007
On Thu, 2007-10-11 at 15:16 +0100, Christoph Hellwig wrote:
> On Thu, Oct 11, 2007 at 11:51:06AM +0200, Holger Schurig wrote:
> > Move wlan_postpone_association_work() and wlan_cancel_association_work()
> > from a assoc.h file to the sole user, into wext.c.
> >
> > In passing, rename the functions to libertas_XXX.
>
> As you seem to do some nice cleanups on libertas is there a chance
> you could get rid of this horrible wlan_ namespace abuse in the driver?
100% agree... That's always been part of the plan, just that other
cleanups were more pressing and time always runs out.
IMHO 'libertas' is too long as a prefix for stuff, and replacing wlan_
with libertas_ is going to screw up spacing everywhere. So, any
objections to, as part of the longer-term plan, replace the usage of
'libertas_' and 'wlan_' with the prefix "lts"? Would look like:
wlan_set_essid -> lts_set_essid
wlan_private -> lts_private
etc
(I don't really like 'lbs' personally but I'm not that strongly against
it)
Dan
More information about the libertas-dev
mailing list