[PATCH 1/3] libertas: remove debugmode

Dan Williams dcbw at redhat.com
Tue Jun 19 13:29:12 EDT 2007


On Tue, 2007-06-19 at 13:27 -0400, Dan Williams wrote:
> On Tue, 2007-06-19 at 17:50 +0200, Holger Schurig wrote:
> > From: Holger Schurig <hs4233 at mail.mn-solutions.de>
> > 
> > There is nowhere any place that set's this variable.
> > 
> > Signed-off-by: Holger Schurig <hs4233 at mail.mn-solutions.de>
> 
> This one is committed

I lied, I didn't commit this one, but the previous fw.c-kill patch.

> > ---
> > 
> >  drivers/net/wireless/libertas/defs.h |    3 ---
> >  drivers/net/wireless/libertas/dev.h  |    1 -
> >  drivers/net/wireless/libertas/rx.c   |    4 ----
> >  drivers/net/wireless/libertas/tx.c   |    8 --------
> >  4 files changed, 0 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/libertas/defs.h b/drivers/net/wireless/libertas/defs.h
> > index eee8a49..e47fadf 100644
> > --- a/drivers/net/wireless/libertas/defs.h
> > +++ b/drivers/net/wireless/libertas/defs.h
> > @@ -149,9 +149,6 @@ static inline void lbs_dbg_hex(char *prompt, u8 * buf, int len)
> >  #define	MRVDRV_CHANNELS_PER_SCAN		4
> >  #define	MRVDRV_MAX_CHANNELS_PER_SCAN		14
> >  
> > -#define MRVDRV_DEBUG_RX_PATH		0x00000001
> > -#define MRVDRV_DEBUG_TX_PATH		0x00000002
> > -
> >  #define MRVDRV_MIN_BEACON_INTERVAL		20
> >  #define MRVDRV_MAX_BEACON_INTERVAL		1000
> >  #define MRVDRV_BEACON_INTERVAL			100
> > diff --git a/drivers/net/wireless/libertas/dev.h b/drivers/net/wireless/libertas/dev.h
> > index 6acb8fb..7c565cb 100644
> > --- a/drivers/net/wireless/libertas/dev.h
> > +++ b/drivers/net/wireless/libertas/dev.h
> > @@ -393,7 +393,6 @@ struct _wlan_adapter {
> >  	u16 txrate;
> >  	u32 linkmode;
> >  	u32 radiomode;
> > -	u32 debugmode;
> >  	u8 fw_ready;
> >  
> >  	u8 last_scanned_channel;
> > diff --git a/drivers/net/wireless/libertas/rx.c b/drivers/net/wireless/libertas/rx.c
> > index a84e100..da3b7d1 100644
> > --- a/drivers/net/wireless/libertas/rx.c
> > +++ b/drivers/net/wireless/libertas/rx.c
> > @@ -172,10 +172,6 @@ int libertas_process_rxed_packet(wlan_private * priv, struct sk_buff *skb)
> >  
> >  	lbs_deb_enter(LBS_DEB_RX);
> >  
> > -	if (priv->adapter->debugmode & MRVDRV_DEBUG_RX_PATH)
> > -		lbs_dbg_hex("RX packet: ", skb->data,
> > -			 min_t(unsigned int, skb->len, 100));
> > -
> >  	if (priv->adapter->linkmode == WLAN_LINKMODE_802_11)
> >  		return process_rxed_802_11_packet(priv, skb);
> >  
> > diff --git a/drivers/net/wireless/libertas/tx.c b/drivers/net/wireless/libertas/tx.c
> > index 7c38301..7743d3f 100644
> > --- a/drivers/net/wireless/libertas/tx.c
> > +++ b/drivers/net/wireless/libertas/tx.c
> > @@ -72,10 +72,6 @@ static int SendSinglePacket(wlan_private * priv, struct sk_buff *skb)
> >  	if (priv->adapter->surpriseremoved)
> >  		return -1;
> >  
> > -	if ((priv->adapter->debugmode & MRVDRV_DEBUG_TX_PATH) != 0)
> > -		lbs_dbg_hex("TX packet: ", skb->data,
> > -			 min_t(unsigned int, skb->len, 100));
> > -
> >  	if (!skb->len || (skb->len > MRVDRV_ETH_TX_PACKET_BUFFER_SIZE)) {
> >  		lbs_deb_tx("tx err: skb length %d 0 or > %zd\n",
> >  		       skb->len, MRVDRV_ETH_TX_PACKET_BUFFER_SIZE);
> > @@ -267,10 +263,6 @@ void libertas_send_tx_feedback(wlan_private * priv)
> >  
> >  	radiotap_hdr = (struct tx_radiotap_hdr *)adapter->currenttxskb->data;
> >  
> > -	if ((adapter->debugmode & MRVDRV_DEBUG_TX_PATH) != 0)
> > -		lbs_dbg_hex("TX feedback: ", (u8 *) radiotap_hdr,
> > -			min_t(unsigned int, adapter->currenttxskb->len, 100));
> > -
> >  	txfail = (status >> 24);
> >  
> >  #if 0
> > 
> > _______________________________________________
> > libertas-dev mailing list
> > libertas-dev at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/libertas-dev
> 
> 
> _______________________________________________
> libertas-dev mailing list
> libertas-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libertas-dev




More information about the libertas-dev mailing list