[PATCH] region code is 8bit

Holger Schurig hs4233 at mail.mn-solutions.de
Mon Aug 6 03:53:51 EDT 2007


> -       adapter->regioncode = le16_to_cpu(hwspec->regioncode);
> +       adapter->regioncode = (le16_to_cpu(hwspec->regioncode)
> & 0xff);

You don't need to bracket this:

  adapter->regioncode = (le16_to_cpu(hwspec->regioncode) & 0xff);
  adapter->regioncode = le16_to_cpu(hwspec->regioncode) & 0xff;

is equivalent. But the latter is less confusing, because someone 
who looks in a hurry is less likely to confuse this with

  adapter->regioncode = (le16_to_cpu(hwspec->regioncode & 0xff));



More information about the libertas-dev mailing list